[PATCH] D82923: introducing llvm-libtool-darwin

Wed Jul 8 07:07:49 PDT 2020

sameerarora101 marked 5 inline comments as done.
sameerarora101 added inline comments.

================
Comment at: llvm/docs/CommandGuide/llvm-libtool-darwin.rst:17
+
+For most scenarios, it works as a drop-in replacement for cctool's
+:program:`libtool`.
----------------
smeenai wrote:
> Nit: The package name is "cctools", so you should say "cctools'" (trailing apostrophe) instead of "cctool's".
good catch, thanks 😊

================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:18
+
+static cl::opt<std::string> OutputFile("output",
+                                       cl::desc("Specify output filename"),
----------------
smeenai wrote:
> As far as I can see, cctools libtool doesn't support the `-output` spelling, only `-o`. Is there any reason for us to support it?
Yup, that is true. I was just looking at other llvm tools and they have `-output` in addition to `-o`. So I thought of adding both. I can remove `-output` if you guys prefer that?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82923/new/

https://reviews.llvm.org/D82923