[PATCH] D82923: introducing llvm-libtool-darwin

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.

LGTM.



================
Comment at: llvm/docs/CommandGuide/llvm-libtool-darwin.rst:17
+
+For most scenarios, it works as a drop-in replacement for cctool's
+:program:`libtool`.
----------------
Nit: The package name is "cctools", so you should say "cctools'" (trailing apostrophe) instead of "cctool's".


================
Comment at: llvm/test/tools/llvm-libtool-darwin/basic.test:1
+## This test checks that main exits normally (EC 0) for correct input/output args.
+
----------------
Nit: just spell out "error code" instead of abbreviating it as EC.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:18
+
+static cl::opt<std::string> OutputFile("output",
+                                       cl::desc("Specify output filename"),
----------------
As far as I can see, cctools libtool doesn't support the `-output` spelling, only `-o`. Is there any reason for us to support it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82923/new/

https://reviews.llvm.org/D82923