[PATCH] D83314: [llvm-readobj] - Refine error reporting in MipsGOTParser<ELFT> helper.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 00:00:28 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-plt.test:127
+
+## Check we report errors when we are unable to dump PLTGOT table properly.
+
----------------
"to dump the PLTGOT properly"

(GOT stands for Global Offset Table, so no need to say "table" again).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83314/new/

https://reviews.llvm.org/D83314





More information about the llvm-commits mailing list