[PATCH] D83314: [llvm-readobj] - Refine error reporting in MipsGOTParser<ELFT> helper.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 08:28:44 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, atanasyan.
Herald added subscribers: rupprecht, arichardson, sdardis, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This is a follow-up for D83225 <https://reviews.llvm.org/D83225>. This does the following:

1. Adds missing tests for existent errors.
2. Stops using `unwrapOrError` to propagate errors to caller. (I am trying to get rid of all `unwrapOrErr` calls in the llvm-readelf code).
3. Improves error messages reported slightly.


https://reviews.llvm.org/D83314

Files:
  llvm/test/tools/llvm-readobj/ELF/mips-got.test
  llvm/test/tools/llvm-readobj/ELF/mips-plt.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83314.276080.patch
Type: text/x-patch
Size: 5122 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200707/c987f0ed/attachment.bin>


More information about the llvm-commits mailing list