[PATCH] D78861: [Attributor] [WIP] Track AA dependency using dependency graph

[Luofan Chen via Phabricator via llvm-commits]

bbn marked an inline comment as done.
bbn added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:863
              CallGraphUpdater &CGUpdater,
+             AADepGraphNode &SynDGN,
              DenseSet<const char *> *Allowed = nullptr)
----------------
kuter wrote:
> Why ? 
> 
> Currently you are passing a synthetic node reference from outside
> and doing 
> A.DG =  ... 
> in  `runAttributorOnFunctions`
> 
> Since the graph is now so light weight why don't we do it like `Attributor::getDepGraph()` ? 
> `getDepGraph()` would just return a `AADepGraph` with a reference to the `SynDGN`
> Doing it this way you wouldn't have to set the DG from outside + you wouldn't need 
> to store a `AADepGraphNode` reference.
> 
Thanks for the idea. I have updated my patch and moved the synthetic node to the dependency graph, does that make sense?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78861/new/

https://reviews.llvm.org/D78861