[PATCH] D78861: [Attributor] [WIP] Track AA dependency using dependency graph

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:863
              CallGraphUpdater &CGUpdater,
+             AADepGraphNode &SynDGN,
              DenseSet<const char *> *Allowed = nullptr)
----------------
Why ? 

Currently you are passing a synthetic node reference from outside
and doing 
A.DG =  ... 
in  `runAttributorOnFunctions`

Since the graph is now so light weight why don't we do it like `Attributor::getDepGraph()` ? 
`getDepGraph()` would just return a `AADepGraph` with a reference to the `SynDGN`
Doing it this way you wouldn't have to set the DG from outside + you wouldn't need 
to store a `AADepGraphNode` reference.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78861/new/

https://reviews.llvm.org/D78861