[PATCH] D79635: [RISCV] Split the pseudo instruction splitting pass

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

In D79635#2125922 <https://reviews.llvm.org/D79635#2125922>, @lenary wrote:

> The broader point is also correct though: lots of passes which check if a MBB has its address taken, don't also check if the label must be emitted, which this code "assumes". Updating these passes isn't always going to be easy.


I got the impression from Lewis' comments in D54143 <https://reviews.llvm.org/D54143> that using `LabelMustBeEmitted` instead of `AddressTaken` was mostly to avoid the segfault issues in the AsmPrinter, so I wonder if we can just use both (or some other solution that moves more toward using `AddressTaken` only), instead of trying to fix all of the passes that aren't aware of `LabelMustBeEmitted`. Regarding the performance costs of `AddressTaken`, we can compare the cost of that vs the benefit of moving the expansions earlier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79635/new/

https://reviews.llvm.org/D79635