[PATCH] D79635: [RISCV] Split the pseudo instruction splitting pass

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 10:15:47 PDT 2020


lenary added a comment.

In D79635#2125887 <https://reviews.llvm.org/D79635#2125887>, @nickdesaulniers wrote:

> Should these blocks just be manually split, that way you don't have to hack around tracking that an arbitrary instruction in the stream is a branch target?


These blocks *are* manually split. The problem is later passes don't check `hasLabelMustBeEmitted` which can cause them to get re-merged (say if the prior block is empty), at which point the label becomes invalid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79635/new/

https://reviews.llvm.org/D79635





More information about the llvm-commits mailing list