[PATCH] D81587: [GlobalISel] Add missing properties to G_BRINDIRECT, G_BRJT

Dominik Montada via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 10:32:22 PDT 2020


gargaroff added a comment.

I noticed the missing properties when implementing `analyzeBranch` for our downstream target. Since the machine verifier also uses this function, all of the GMIR was passing through it and we were getting false-positives for those two instructions. Seems like an obvious fix. I guess the two tests changed because now there is no implicit fall-through, which marks the basic block as a successor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81587/new/

https://reviews.llvm.org/D81587





More information about the llvm-commits mailing list