[PATCH] D81585: [AIX][XCOFF] Decode trace back table information for xcoff object file for llvm-objdump -d

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 09:57:14 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:54
 Optional<XCOFF::StorageMappingClass>
-objdump::getXCOFFSymbolCsectSMC(const XCOFFObjectFile *Obj,
-                                const SymbolRef &Sym) {
+getXCOFFSymbolCsectSMC(const XCOFFObjectFile *Obj, const SymbolRef &Sym) {
   XCOFFSymbolRef SymRef(Sym.getRawDataRefImpl(), Obj);
----------------
Dropping `objdump::` is unnecessary and does not conform to the coding standards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585





More information about the llvm-commits mailing list