[PATCH] D81585: [AIX][XCOFF] Decode trace back table information for xcoff object file for llvm-objdump -d

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 09:57:10 PDT 2020


DiggerLin created this revision.
DiggerLin added reviewers: jasonliu, hubert.reinterpretcast, jhenderson.
Herald added subscribers: llvm-commits, rupprecht, MaskRay.
Herald added a reviewer: MaskRay.
Herald added a project: LLVM.
MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:54
 Optional<XCOFF::StorageMappingClass>
-objdump::getXCOFFSymbolCsectSMC(const XCOFFObjectFile *Obj,
-                                const SymbolRef &Sym) {
+getXCOFFSymbolCsectSMC(const XCOFFObjectFile *Obj, const SymbolRef &Sym) {
   XCOFFSymbolRef SymRef(Sym.getRawDataRefImpl(), Obj);
----------------
Dropping `objdump::` is unnecessary and does not conform to the coding standards.


1. added  a new option --traceback-table to decode the  trace back table information for xcoff object file when

using llvm-objdump  to disassemble the xcoff objfile


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81585

Files:
  llvm/docs/CommandGuide/llvm-objdump.rst
  llvm/include/llvm/BinaryFormat/XCOFF.h
  llvm/test/tools/llvm-objdump/XCOFF/Inputs/xcoff-func-tracebacktable.o
  llvm/test/tools/llvm-objdump/XCOFF/disassemble-tracebacktable.test
  llvm/tools/llvm-objdump/XCOFFDump.cpp
  llvm/tools/llvm-objdump/XCOFFDump.h
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81585.269879.patch
Type: text/x-patch
Size: 24196 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200610/d5fa09f7/attachment-0001.bin>


More information about the llvm-commits mailing list