[PATCH] D81553: [VE] Support relocation information in MC layer

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 planned changes to this revision.
kaz7 marked an inline comment as done.
kaz7 added a comment.

I'll check manuals of assembler for Aurora and update this patch.  Thanks.



================
Comment at: llvm/lib/Target/VE/AsmParser/VEAsmParser.cpp:973
+  case MCExpr::SymbolRef: {
+    const MCSymbolRefExpr &SymRef = *cast<MCSymbolRefExpr>(Expr);
+    return (SymRef.getSymbol().getName() == "_GLOBAL_OFFSET_TABLE_");
----------------
simoll wrote:
> `const auto&`? In any case, l968 and l973 should use the same types (currently the above uses a `*` whereas it's a `&` below).
Thanks.  I've missed it again.  On the other hand, I may remove this function based on Sparc implementation.  While I've checking this function based on your suggestion, I've noticed this function is used to convert `@hi` to `@pc_hi` or `@got_hi` but the Nas doesn't have such functionality.  I'll check more deeply.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81553/new/

https://reviews.llvm.org/D81553