[PATCH] D81553: [VE] Support relocation information in MC layer

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

LGTM with one minor nit. Thanks!



================
Comment at: llvm/lib/Target/VE/AsmParser/VEAsmParser.cpp:973
+  case MCExpr::SymbolRef: {
+    const MCSymbolRefExpr &SymRef = *cast<MCSymbolRefExpr>(Expr);
+    return (SymRef.getSymbol().getName() == "_GLOBAL_OFFSET_TABLE_");
----------------
`const auto&`? In any case, l968 and l973 should use the same types (currently the above uses a `*` whereas it's a `&` below).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81553/new/

https://reviews.llvm.org/D81553