[PATCH] D81403: Work around GlobalISel limitation on Indirect Thunks.

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 07:37:39 PDT 2020


kristof.beyls marked an inline comment as done.
kristof.beyls added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2496
 
-  assert(&MF->front() == &NewEntryBB &&
-         "New entry wasn't next in the list of basic block!");
+  if (&MF->front() != &NewEntryBB) {
+    OptimizationRemarkMissed R("gisel-irtranslator", "GISelFailure",
----------------
arsenm wrote:
> Why was this violated? Seems like it should be straightforward to fix? Can you add a pure IR test that just runs the IRTranslator?
The violation comes from thunks produced by the ThunkInserter. They are naked functions, not sure if that could trigger this issue.
I'll look into if it's possible to have a pure IR test trigger this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81403/new/

https://reviews.llvm.org/D81403





More information about the llvm-commits mailing list