[PATCH] D81403: Work around GlobalISel limitation on Indirect Thunks.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 09:56:47 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2496
 
-  assert(&MF->front() == &NewEntryBB &&
-         "New entry wasn't next in the list of basic block!");
+  if (&MF->front() != &NewEntryBB) {
+    OptimizationRemarkMissed R("gisel-irtranslator", "GISelFailure",
----------------
Why was this violated? Seems like it should be straightforward to fix? Can you add a pure IR test that just runs the IRTranslator?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81403/new/

https://reviews.llvm.org/D81403





More information about the llvm-commits mailing list