[PATCH] D81295: lld: initial pass at supporting TBD

Mon Jun 8 11:35:22 PDT 2020

compnerd marked 2 inline comments as done.
compnerd added inline comments.

================
Comment at: lld/test/MachO/iPhoneSimulator.sdk/usr/lib/libSystem.tbd:1
+--- !tapi-tbd-v3
+archs:            [ i386, x86_64 ]
----------------
Ktwu wrote:
> It's nice to know where these files came from, but there's not a need to create a full copy that even preserves the path, right? If anything, you should be able to combine the two stub files into one manually and use them both for your test.
> 
> 
> For example, you don't use __crashreporeter_info__, so get rid of it.
Keeping them separate is important IMO, and far more useful.  This is going to grow over time, and get used for future tests as the functionality improves.  The paths here are not indicative of where they originate from - the UUIDs are pretty obviously sequential - as these are fabricated.  The versions happen to be cause I had a tab open to some revision of opensource.apple.com.

The single symbol there is there because its useful for testing symbol origins from the parent umbrella vs re-exported dylibs.

================
Comment at: lld/test/MachO/stub-link-2.s:1
+# REQUIRES: x86
+
----------------
Ktwu wrote:
> stub-link-2 isn't descriptive. Move this into /test/MachO/invalid and give it a better name like "undefined-stub-symbol"?
Its not really an invalid test, its a negative test case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81295/new/

https://reviews.llvm.org/D81295