[PATCH] D81295: lld: initial pass at supporting TBD

Mon Jun 8 10:30:23 PDT 2020

Ktwu added a comment.

>   This is largely incomplete, not filtering out platforms and architectures. 

Not true anymore :D

> potentially does not correct handle trees of re-exports with inlined

libraries being treated as direct children of the top level library.

Add a TODO?

================
Comment at: lld/test/MachO/iPhoneSimulator.sdk/usr/lib/libSystem.tbd:1
+--- !tapi-tbd-v3
+archs:            [ i386, x86_64 ]
----------------
It's nice to know where these files came from, but there's not a need to create a full copy that even preserves the path, right? If anything, you should be able to combine the two stub files into one manually and use them both for your test.

For example, you don't use __crashreporeter_info__, so get rid of it.

================
Comment at: lld/test/MachO/stub-link-2.s:1
+# REQUIRES: x86
+
----------------
stub-link-2 isn't descriptive. Move this into /test/MachO/invalid and give it a better name like "undefined-stub-symbol"?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81295/new/

https://reviews.llvm.org/D81295