[PATCH] D80684: [LiveDebugValues] Speed up removeEntryValue, NFC

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/ADT/CoalescingBitVector.h:363
+    if (StartIt == end() || *StartIt >= End)
+      return {end(), end()};
+    auto EndIt = StartIt;
----------------
It's weird that this empty range violates the assertion on line 360, but I think that is okay.

Is `*StartIt >= End` even possible, given the assertion?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:136
+  /// kind RegisterKind.
+  static constexpr uint32_t kFirstInvalidRegLocation = 1 << 30;
+
----------------
what does the `k` stand for?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1362
+             VL.Kind == VarLoc::SpillLocKind && "Broken VarLocSet?");
+      if (VL.Loc.SpillLocation == *Loc)
+        LLVM_DEBUG(dbgs() << "Restoring Register " << printReg(Reg, TRI) << '('
----------------
```
if (VL.Loc.SpillLocation != *Loc)
  // Comment explains why no pair is inserted...
  continue;
LLVM_DEBUG(dbgs() << "Restoring Register " ...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80684/new/

https://reviews.llvm.org/D80684