[PATCH] D80684: [LiveDebugValues] Speed up removeEntryValue, NFC

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

The implementation here looks good, and should lead to some kind of speedup. I'll leave approving to @djtodoro as he knows the entry value mechanisms better.



================
Comment at: llvm/unittests/ADT/CoalescingBitVectorTest.cpp:506
+    EXPECT_TRUE(rangesMatch(BV.half_open_range(2, 4), {2, 3}));
+    EXPECT_TRUE(rangesMatch(BV.half_open_range(4, 5), {}));
+  }
----------------
IMHO, we should also test a Start >= End case, as that's a condition in half_open_range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80684/new/

https://reviews.llvm.org/D80684