[PATCH] D80368: Remove GlobalValue::getAlignment().

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Minor note. I think if we don't get a complaint this is OK.



================
Comment at: llvm/lib/IR/Globals.cpp:113
-    // Alias = Absolute
-    return 0;
-  }
----------------
Yeah, this seems wrong.


================
Comment at: llvm/lib/LTO/LTOModule.cpp:418
   // set alignment part log2() can have rounding errors
-  uint32_t align = def->getAlignment();
+  uint32_t align = 0;
+  const GlobalObject *go = dyn_cast<GlobalObject>(def);
----------------
Isn't 1 the right choice here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80368/new/

https://reviews.llvm.org/D80368