[PATCH] D80368: Remove GlobalValue::getAlignment().

Nigel Perks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 02:08:10 PDT 2020


nigelp-xmos added inline comments.


================
Comment at: llvm/lib/Target/XCore/XCoreISelLowering.cpp:438
     if (TLI.isGAPlusOffset(BasePtr.getNode(), GV, Offset) &&
-        MinAlign(GV->getAlignment(), 4) == 4) {
+        GV->getPointerAlignment(DAG.getDataLayout()) >= 4) {
       SDValue NewBasePtr = DAG.getGlobalAddress(GV, DL,
----------------
Looks good on XCore. (I am not an approver. I have only reviewed for XCore.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80368/new/

https://reviews.llvm.org/D80368





More information about the llvm-commits mailing list