[PATCH] D80496: [ELF] Add -z rel and -z rela

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 01:35:11 PDT 2020


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a last comment addressed.
Probably hold this a bit to give other people chance to look too.



================
Comment at: lld/test/ELF/i386-zrela.s:30
+
+# RUN: ld.lld -shared -z rel -z rela %t.o -o %t2.so
+# RUN: llvm-readobj -d -r %t2.so | FileCheck --check-prefix=RELA %s
----------------
MaskRay wrote:
> grimar wrote:
> > I think you need to have just `-z rela` too.
> This is to show that the last of `rel` and `rela` wins.
Yes, I understood that. I mean you have "-z rel -z rela" case, what is fine, but do not have a case when "-z rela" is just alone.
(what is actually a more real use case)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80496/new/

https://reviews.llvm.org/D80496





More information about the llvm-commits mailing list