[PATCH] D80496: [ELF] Add -z rel and -z rela

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/i386-zrela.s:30
+
+# RUN: ld.lld -shared -z rel -z rela %t.o -o %t2.so
+# RUN: llvm-readobj -d -r %t2.so | FileCheck --check-prefix=RELA %s
----------------
grimar wrote:
> I think you need to have just `-z rela` too.
This is to show that the last of `rel` and `rela` wins.


================
Comment at: lld/test/ELF/i386-zrela.s:43
+# RELA-NEXT:   R_386_TLS_TPOFF tls 0x2A
+# RELA-NEXT:   R_386_32 _start 0x2A
+# RELA-NEXT: }
----------------
grimar wrote:
> Does it worth to show what happens for `R_386_RELATIVE`?
Worthy. Added


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80496/new/

https://reviews.llvm.org/D80496