[PATCH] D79787: [IndVarSimplify][LoopUtils] Avoid TOCTOU/ordering issues (PR45835)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 21 02:08:39 PDT 2020


lebedev.ri added a comment.

In D79787#2048569 <https://reviews.llvm.org/D79787#2048569>, @mkazantsev wrote:

> > I don't have an actionable example at hand. I could just drop FIXME if it's too weird.
>
> Then please add a debug printout that it happened.


I'm sorry, i'm not sure i follow. It's not a bug, it's a potential improvement.
There is no point in trying to detect such a situation right now
because it will bring no benefit but will cost us compile time.

> Otherwise I don't have much objections. LGTM.

Thank you for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79787/new/

https://reviews.llvm.org/D79787





More information about the llvm-commits mailing list