[PATCH] D79787: [IndVarSimplify][LoopUtils] Avoid TOCTOU/ordering issues (PR45835)

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

> I don't have an actionable example at hand. I could just drop FIXME if it's too weird.

Then please add a debug printout that it happened.

Otherwise I don't have much objections. LGTM.



================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:1226
+  Value *Expansion = nullptr;
+  bool IsValidRewrite = false;
+
----------------
Better call it `ValidRewrite` because of `HighCost` without `Is` above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79787/new/

https://reviews.llvm.org/D79787