[PATCH] D80056: GlobalISel: Merge G_PTR_MASK with llvm.ptrmask intrinsic

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: llvm/include/llvm/Support/TargetOpcodes.def:554
+/// Clear the specified bits in a pointer.
+HANDLE_TARGET_OPCODE(G_PTRMASK)
 
----------------
Did you mean to drop the underscore? It's inconsistent with G_PTR_ADD now


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1105-1120
+  case TargetOpcode::G_PTRMASK: {
+    LLT DstTy = MRI->getType(MI->getOperand(0).getReg());
+    LLT SrcTy = MRI->getType(MI->getOperand(1).getReg());
+    LLT MaskTy = MRI->getType(MI->getOperand(2).getReg());
+    if (!DstTy.isValid() || !SrcTy.isValid() || !MaskTy.isValid())
+      break;
+
----------------
Could you add these requirements to GenericOpcodes.rst (and correct the semantics in that description too)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80056/new/

https://reviews.llvm.org/D80056