[PATCH] D80056: GlobalISel: Merge G_PTR_MASK with llvm.ptrmask intrinsic

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 15:12:24 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/test/MachineVerifier/test_g_ptrmask.mir:19
+
+    ; CHECK:  Bad machine code: Type mismatch in generic instruction
+    %4:_(p0) = G_PTRMASK %2, %2
----------------
gargaroff wrote:
> Should the verifier report where the type mismatch is? It already reports if the destination of the mask is incorrect. Shouldn't it do the same for the source?
Generally the verifier seems to just try every single check independently and produce every error it can, even if it's redundant


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80056/new/

https://reviews.llvm.org/D80056





More information about the llvm-commits mailing list