[PATCH] D79820: [test] Improve FileCheck's numeric-expression.txt

Fri May 15 00:52:28 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with a couple of nits.

================
Comment at: llvm/test/FileCheck/numeric-expression.txt:12
+DEF DEFAULT FMT SPC  // CHECK-LABEL: DEF DEFAULT FMT SPC
+11  // CHECK-NEXT: {{^}}[[# UNSIa:]]
+11  // CHECK-NEXT: {{^}}[[# UNSIb :]]
----------------
I'm not sure I follow why in some cases, you've added `{{^}}`, but not in others. It looks like here for example, it's not needed.

================
Comment at: llvm/test/FileCheck/numeric-expression.txt:17-18
 ; Numeric variable redefinition.
-REDEF NO SPC
-11
-CHECK-LABEL: REDEF
-CHECK-NEXT: [[#VAR1:]]
+REDEF NO SPC  // CHECK-LABEL: REDEF
+11 // CHECK-NEXT: [[#UNSI:]]

----------------
Nit: throughout, in most places you've used two spaces before the start of the comment, but on this line at least, you've used 1. Probably you should be consistent. I have a marginal preference for 1, but don't mind 2 if it looks better to you.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79820/new/

https://reviews.llvm.org/D79820