[PATCH] D79820: [test] Improve FileCheck's numeric-expression.txt

[Joel E. Denny via Phabricator via llvm-commits]

jdenny accepted this revision.
jdenny added a comment.

LGTM again.



================
Comment at: llvm/test/FileCheck/numeric-expression.txt:228-236
 STRVAR NUMVAR CONFLICT
 redef1 42
 foobar
 redef2 42
 CONFLICT-LABEL: STRVAR NUMVAR CONFLICT
 CONFLICT1-NEXT: redef1 [[#NUMVAR:]]
 CONFLICT2: [[NUMVAR:foo.*]]
----------------
thopre wrote:
> jdenny wrote:
> > Can these checks be inlined like the others?
> I'm not too keen on it for 2 reasons:
> 
>   -  CONFLICT2 and CONFLICT3 are both for the foobar line so would have to be interleaved with the input, after foobar. 
>   - having the CHECK on the same line as the input means they appear in the error message and makes the error message checking directives even longer
Thanks for explaining.  It doesn't seem important enough to me to debate further.  Unless @jhenderson objects, let's move on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79820/new/

https://reviews.llvm.org/D79820