[PATCH] D79328: lld: Let find_package(LLD) work

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/cmake/modules/CMakeLists.txt:33
+# Compute the installation prefix from this LLVMConfig.cmake file location.
+get_filename_component(LLD_INSTALL_PREFIX \"\${CMAKE_CURRENT_LIST_FILE}\" PATH)")
+# Construct the proper number of get_filename_component(... PATH)
----------------
Does this need an indentation?


================
Comment at: lld/cmake/modules/CMakeLists.txt:39
+  set(LLD_CONFIG_CODE "${LLD_CONFIG_CODE}
+get_filename_component(LLD_INSTALL_PREFIX \"\${LLD_INSTALL_PREFIX}\" PATH)")
+endforeach(p)
----------------
Not indented?


================
Comment at: lld/cmake/modules/CMakeLists.txt:44
+set(LLD_CONFIG_EXPORTS_FILE "\${LLD_CMAKE_DIR}/LLDTargets.cmake")
+set(LLD_CONFIG_INCLUDE_DIRS
+  "\${LLD_INSTALL_PREFIX}/include"
----------------
This does not need a line wrap.


================
Comment at: lld/cmake/modules/LLDConfig.cmake.in:18
+# in-tree with lld or not.
+if(NOT TARGET lld-tablegen-targets)
+  add_custom_target(lld-tablegen-targets)
----------------
Is this used?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79328/new/

https://reviews.llvm.org/D79328