[PATCH] D79328: lld: Let find_package(LLD) work

Wed May 13 18:02:24 PDT 2020

arsenm added a comment.

In D79328#2035419 <https://reviews.llvm.org/D79328#2035419>, @MaskRay wrote:

> I usually just follow the executable name and call it `lld`. In patch subjects, I follow pre-git layout and just use `[ELF] ` and don't bother adding `[lld] `.
>  I see `LLD` is common, too. `LLD` is the string `lld-link` and `ld.lld` --version print:
>
> % ld.lld --version
>  LLD 11.0.0 (compatible with GNU linkers)
>
> I think either is ok.
>
>  --------
>
> For this patch, what does it intend to achieve? `find_package(LLD)`, link against `lldCOFF`, `lldELF` etc, and call `lld::elf::link`, `lld::wasm::link`?
>
> It'd be nice if you have an out-of-tree project or something which demonstrates that `find_package(LLD)` works, if you do want to use lld this way.

This is to fix this <https://github.com/RadeonOpenCompute/ROCm-CompilerSupport/blob/6a81326fa9c95f2045064554c471f2568d8c6e7b/lib/comgr/CMakeLists.txt#L34>

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79328/new/

https://reviews.llvm.org/D79328