[PATCH] D76882: [AMDGPU] Implement CFI for non-kernel functions

Christudasan Devadasan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 07:00:10 PDT 2020


cdevadas added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:42
 
+static ArrayRef<MCPhysReg> getAllVGPRs(const GCNSubtarget &ST,
+                                       const MachineFunction &MF) {
----------------
I think it is good to move getAllSGPRs and getAllVGPRs into SIRegisterInfo.cpp.
There is another function getAllVGPR32 which does the same thing as getAllVGPRs.
We can unify these instances.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76882/new/

https://reviews.llvm.org/D76882





More information about the llvm-commits mailing list