[PATCH] D79410: [MLIR] [OpenMP] Add basic OpenMP parallel operation

Tue May 5 13:31:10 PDT 2020

rriddle added inline comments.

================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:80
+
+def ParallelOp : OpenMP_Op<"parallel", [AttrSizedOperandSegments]>,
+  Arguments<(ins Optional<I1>:$if_expr_var,
----------------
DavidTruby wrote:
> rriddle wrote:
> > Is there a logical ordering of some kind you can establish for this file, e.g., alphabetical?
> The order they're in here is the order they're in in the OpenMP specification. I can change it to be alphabetical or otherwise though
That makes sense, it wasn't clear that there was an order on first glance. Can you add comment blocks to make this a bit cleaner?

e.g.: https://github.com/llvm/llvm-project/blob/4e9a7c8f5c527e7493394ab7869f38ca7c6b8903/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td#L205

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79410/new/

https://reviews.llvm.org/D79410