[PATCH] D79410: [MLIR] [OpenMP] Add basic OpenMP parallel operation

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 12:58:30 PDT 2020


DavidTruby marked an inline comment as done.
DavidTruby added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:80
+
+def ParallelOp : OpenMP_Op<"parallel", [AttrSizedOperandSegments]>,
+  Arguments<(ins Optional<I1>:$if_expr_var,
----------------
rriddle wrote:
> Is there a logical ordering of some kind you can establish for this file, e.g., alphabetical?
The order they're in here is the order they're in in the OpenMP specification. I can change it to be alphabetical or otherwise though


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79410/new/

https://reviews.llvm.org/D79410





More information about the llvm-commits mailing list