[PATCH] D79387: [clangd] Fix remote index build for macOS with Homebrew-installed gRPC and Protobuf

[Kirill Bobyrev via Phabricator via llvm-commits]

kbobyrev marked an inline comment as done.
kbobyrev added inline comments.


================
Comment at: llvm/cmake/modules/FindGRPC.cmake:24
   find_program(PROTOC protoc)
+  if (${APPLE})
+    find_program(HOMEBREW brew)
----------------
sammccall wrote:
> how does the conditional logic/recovery around this work?
> e.g. what if it's installed in the system, but not via homebrew? What if homebrew is available, but grpc or protobuf are not installed?
For now, there is no recovery or workaround. The only way to have system-installed install grpc + protobuf other than Homebrew would probably be compiling and doing `make install` but I don't think people are happy with doing that (and if they are already building it then it'd be better to use `GRPC_INSTALL_PATH`). Homebrew is de-facto the standard package manager for macOS and while I could check if Homebrew is found and if the packages are install and fall back to the "default" case when if they aren't we assume gRPC headers, libraries and binaries are all in the search paths I think that would be optimising for weird setups nobody is likely to use.

WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79387/new/

https://reviews.llvm.org/D79387