[PATCH] D79387: [clangd] Fix remote index build for macOS with Homebrew-installed gRPC and Protobuf

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 05:53:05 PDT 2020


sammccall added inline comments.


================
Comment at: llvm/cmake/modules/FindGRPC.cmake:24
   find_program(PROTOC protoc)
+  if (${APPLE})
+    find_program(HOMEBREW brew)
----------------
how does the conditional logic/recovery around this work?
e.g. what if it's installed in the system, but not via homebrew? What if homebrew is available, but grpc or protobuf are not installed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79387/new/

https://reviews.llvm.org/D79387





More information about the llvm-commits mailing list