[PATCH] D79042: [llvm] Add interface to drive inlining decision using ML model

[Eric Christopher via llvm-commits]

On Thu, Apr 30, 2020 at 12:53 PM Mircea Trofin via Phabricator <
reviews at reviews.llvm.org> wrote:

> mtrofin added a comment.
>
> In D79042#2011802 <https://reviews.llvm.org/D79042#2011802>, @echristo
> wrote:
>
> > This is pretty cool. I've got one high level question and then a few
> minor things in the patch.
> >
> > High level: Would it be better to split this out even more rather than
> the if/elses in the Inliner? i.e. rather than conditionalizing it just have
> N paths through. It may mean a little bit more duplicated or factored code,
> but would probably be a little easier to read through.
> >
> > Thoughts?
> >
> > -eric
>
>
> I agree - I'll send first some NFC patches cleaning up a bit the current
> code; then, refactor along the lines you suggested. I think there'll end up
> being very little, if any, duplication, too!
>
>
Sweet! Glad it'll work out. (I need to do this for some of the different
optimizer pipelines too which is why I thought about it :)

Thanks :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200430/6ef8a9dc/attachment.html>