[PATCH] D76977: [lld-macho] Implement basic export trie

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 19:27:19 PDT 2020


smeenai added a comment.

In D76977#2009150 <https://reviews.llvm.org/D76977#2009150>, @int3 wrote:

> Post-order wouldn't work because the offsets are from the start of the export trie section, not from the parent node... not sure why it was designed that way :/


Ah, right ... I was initially thinking you could just compute the size of the root node once you reach it and then adjust all the other offsets accordingly, but of course adjusting the offset might change the length of its ULEB encoding, and then you're back in the same situation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76977/new/

https://reviews.llvm.org/D76977





More information about the llvm-commits mailing list