[PATCH] D76977: [lld-macho] Implement basic export trie

[Jez Ng via Phabricator via llvm-commits]

int3 marked 5 inline comments as done.
int3 added inline comments.


================
Comment at: lld/MachO/ExportTrie.cpp:99
+    uint32_t nodeSize = getULEB128Size(flags) + getULEB128Size(info->address);
+    assert(nodeSize < 256);
+    *buf++ = nodeSize;
----------------
int3 wrote:
> smeenai wrote:
> > Why this assert? The nodeSize (or TerminalSize as macho2yaml terms it) is a ULEB128, right?
> nope, it's a byte. Only the offsets are ulebs
nvm, I'm wrong, oops. It's a uleb indeed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76977/new/

https://reviews.llvm.org/D76977