[PATCH] D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/debug-dir-unmapped.test:3
+
+# RUN: not llvm-objcopy -R .rdata %t.in.exe %t.out.exe 2>&1 | FileCheck %s --check-prefixes=ERROR
+
----------------
alexshap wrote:
> nit: 
> 1. --remove-section (I think other tests generally prefer long names)
> 2. since there are no other prefixes in this file - it looks like one doesn't actually need a custom prefix (ERROR) at all,
> i'd use the default one (CHECK)
Fair enough, I'll change that before pushing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78921/new/

https://reviews.llvm.org/D78921