[PATCH] D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 14:04:45 PDT 2020


alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/debug-dir-unmapped.test:3
+
+# RUN: not llvm-objcopy -R .rdata %t.in.exe %t.out.exe 2>&1 | FileCheck %s --check-prefixes=ERROR
+
----------------
nit: 
1. --remove-section (I think other tests generally prefer long names)
2. since there are no other prefixes in this file - it looks like one doesn't actually need a custom prefix (ERROR) at all,
i'd use the default one (CHECK)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78921/new/

https://reviews.llvm.org/D78921





More information about the llvm-commits mailing list