[PATCH] D78975: Make ops with StructAttr's actually verify `isa<TheStruct>`.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 14:02:38 PDT 2020


silvas added inline comments.


================
Comment at: mlir/test/lib/Dialect/Test/TestDialect.cpp:483
 #include "TestOpEnums.cpp.inc"
+namespace mlir {
+#include "TestOpStructs.cpp.inc"
----------------
rriddle wrote:
> Why is the namespace necessary here? I wouldn't expect it to be.
Indeed, removed. I think some prior version of the patch required it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78975/new/

https://reviews.llvm.org/D78975





More information about the llvm-commits mailing list