[PATCH] D78975: Make ops with StructAttr's actually verify `isa<TheStruct>`.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 11:50:43 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/test/lib/Dialect/Test/TestDialect.cpp:483
 #include "TestOpEnums.cpp.inc"
+namespace mlir {
+#include "TestOpStructs.cpp.inc"
----------------
Why is the namespace necessary here? I wouldn't expect it to be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78975/new/

https://reviews.llvm.org/D78975





More information about the llvm-commits mailing list