[PATCH] D78968: [llvm][utils] Update llc test updater documentation

[Zola Bridges via Phabricator via llvm-commits]

zbrid updated this revision to Diff 260532.
zbrid added a comment.

[utils] Update comment to be more specific based on maskray's comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78968/new/

https://reviews.llvm.org/D78968

Files:
  llvm/utils/update_llc_test_checks.py


Index: llvm/utils/update_llc_test_checks.py
===================================================================
--- llvm/utils/update_llc_test_checks.py
+++ llvm/utils/update_llc_test_checks.py
@@ -5,6 +5,11 @@
 This script is a utility to update LLVM 'llc' based test cases with new
 FileCheck patterns. It can either update all of the tests in the file or
 a single test function.
+
+If your function has runtime preemption specifiers (such as dso_local or
+dso_preemptable), then it will not match the regex this script uses when
+deciding which functions need to be updated. Often the runtime preemption
+specifiers are unnecessary for the test and you should delete them.
 """
 
 from __future__ import print_function


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78968.260532.patch
Type: text/x-patch
Size: 723 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200428/f5a6d23c/attachment.bin>