[PATCH] D78968: [llvm][utils] Update llc test updater documentation

[Zola Bridges via Phabricator via llvm-commits]

zbrid added a subscriber: jyknight.
zbrid added a comment.

In D78968#2006646 <https://reviews.llvm.org/D78968#2006646>, @MaskRay wrote:

> Added some users of `update_llc_test_checks.py`.
>
> `link attributes` is not clear. Do you mean `dso_local` or `dso_preemptable`? The problem you described seems like a general stale test problem. Missing `dso_local` may be a problem but I don't know whether that is common. Maybe there are more common problems that are worth mentioning.


The problem is: If dso_local (or any attribute that can be in the same place as dso_local) is an attribute on the function, then the script won't take any action even when there's no reason it should not take action. I am guessing this is a common problem because @jyknight immediately guessed that might be my issue when I was running this script. I assume other people encounter this problem enough it's tribal knowledge among people who use this script.

As for the link attributes terminology, that's what jyknight called it when he guessed my problem. I see that dso_local is called a `runtime preemption specifier`.  https://llvm.org/docs/LangRef.html#runtime-preemption-specifiers

I'll update the patch to say that instead of link attribute and assume that those are the two things that might show up where dso_local shows up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78968/new/

https://reviews.llvm.org/D78968