[PATCH] D78662: [builtins] Support architectures with 16-bit int

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 06:59:30 PDT 2020


aykevl updated this revision to Diff 259548.
aykevl added a comment.

- defined two macros `clzsi` and `ctzsi` for counting bits in `si_int` and `su_int`
- changed `int32_t` to `si_int` in two places

I believe this addresses all review comments.
I'm not entirely sure about the `clzsi`/`ctzsi` macros. The name seems clear enough, but perhaps they are too close to `__clzsi2`/`__ctzsi2`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78662/new/

https://reviews.llvm.org/D78662

Files:
  compiler-rt/lib/builtins/absvsi2.c
  compiler-rt/lib/builtins/ashldi3.c
  compiler-rt/lib/builtins/ashrdi3.c
  compiler-rt/lib/builtins/clzdi2.c
  compiler-rt/lib/builtins/ctzdi2.c
  compiler-rt/lib/builtins/ffsdi2.c
  compiler-rt/lib/builtins/ffssi2.c
  compiler-rt/lib/builtins/floatdisf.c
  compiler-rt/lib/builtins/floatsidf.c
  compiler-rt/lib/builtins/floatundisf.c
  compiler-rt/lib/builtins/floatunsidf.c
  compiler-rt/lib/builtins/fp_extend.h
  compiler-rt/lib/builtins/fp_lib.h
  compiler-rt/lib/builtins/int_div_impl.inc
  compiler-rt/lib/builtins/int_types.h
  compiler-rt/lib/builtins/lshrdi3.c
  compiler-rt/lib/builtins/popcountdi2.c
  compiler-rt/lib/builtins/udivmoddi4.c
  compiler-rt/test/builtins/Unit/ashldi3_test.c
  compiler-rt/test/builtins/Unit/ashrdi3_test.c
  compiler-rt/test/builtins/Unit/ctzdi2_test.c
  compiler-rt/test/builtins/Unit/ffsdi2_test.c
  compiler-rt/test/builtins/Unit/ffssi2_test.c
  compiler-rt/test/builtins/Unit/lshrdi3_test.c
  compiler-rt/test/builtins/Unit/popcountdi2_test.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78662.259548.patch
Type: text/x-patch
Size: 15964 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200423/a33a514e/attachment-0001.bin>


More information about the llvm-commits mailing list