[PATCH] D78617: [UpdateTestChecks] Make generation of UTC_ARGS: comment more robust

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 10:52:55 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, except that we might need an explicit test, see below.



================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.initially_disabled.expected:10
+
+; UTC_ARGS: --disable
+
----------------
I'm afraid with this line we do not test if the disable in the first line has an effect. We might need another test, sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78617/new/

https://reviews.llvm.org/D78617





More information about the llvm-commits mailing list