[PATCH] D78617: [UpdateTestChecks] Make generation of UTC_ARGS: comment more robust

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 02:40:26 PDT 2020


arichardson created this revision.
arichardson added a reviewer: jdoerfert.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
arichardson added a child revision: D78618: [UpdateTestChecks] Move more update_test_checks.py logic to common.py.

We now use the argparse Action objects to determine the name of the flags.
This fixes cases where the key for the stored result ('dest') is not the
same as the command line flag (e.g. --enable/--disable).
Also add a test that --disabled can be part of the initial UTC_ARGS.

This is split out from D78478 <https://reviews.llvm.org/D78478>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78617

Files:
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.initially_disabled.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/on_the_fly_arg_change.test
  llvm/utils/UpdateTestChecks/common.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78617.259207.patch
Type: text/x-patch
Size: 4520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200422/13c23125/attachment.bin>


More information about the llvm-commits mailing list