[PATCH] D78503: RFC: [ValueTracking] Let analyses assume a value cannot be partially poison

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 10:14:49 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/test/Analysis/ScalarEvolution/nsw.ll:242
   ret void
 }
 
----------------
jdoerfert wrote:
> Given the name of the function I tried to figure out what the reasoning here is.
> 1) This patch is not NFC. Maybe split the wording changes from the functional ones.
> 2) It seems valid to derive both nuw and nsw here but we should confirm with the history and the author of this test.
Forget the NFC part but we could still split the wording changes from the rest ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78503/new/

https://reviews.llvm.org/D78503





More information about the llvm-commits mailing list