[PATCH] D78503: RFC: [ValueTracking] Let analyses assume a value cannot be partially poison

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PoisonChecking.cpp:347
    - and/or - It would seem reasonable for poison to propagate from both
-     arguments, but LangRef doesn't state and propagatesFullPoison doesn't
-     include these two.
+     arguments, but LangRef doesn't state.
    - all binary ops w/vector operands - The likely interpretation would be that
----------------
Is this true? I mean, don't you check for binary operands above?


================
Comment at: llvm/test/Analysis/ScalarEvolution/nsw.ll:242
   ret void
 }
 
----------------
Given the name of the function I tried to figure out what the reasoning here is.
1) This patch is not NFC. Maybe split the wording changes from the functional ones.
2) It seems valid to derive both nuw and nsw here but we should confirm with the history and the author of this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78503/new/

https://reviews.llvm.org/D78503